Exclude namespaces for embedded schemas if they are the same as root schema namespace

php-kafka / php-avro-schema-generator

PHP avro subschema merger and experimental PHP Class avro schema generator

BSD 3-Clause "New" or "Revised" License

5 stars 5 forks source link

Exclude namespaces for embedded schemas if they are the same as root schema namespace #4

Closed bajdzun closed 2 years ago

bajdzun commented 2 years ago

According to flix-tech/avro-php library when schema (after merging with avro:subschema:merge) is parsed it will not contain namespaces for embedded schemas if they are the same as root schema namespace.

I suggest this (or similar) change to follow the same behaviour.

healerz commented 2 years ago

@nick-zh can you have a look as well and if all is good release it? 🙂 (btw, why can't I request a review from you in this repository?)