visibility changed from private to protected for property that can be…

php-kitchen / yii2-domain

DDD for Yii2 [In active development - early alpha]

MIT License

35 stars 6 forks source link

visibility changed from private to protected for property that can be… #39

Closed gh0ti closed 1 year ago

gh0ti commented 4 years ago

… redefined in parent classes

Question	Answer
Is bugfix?	no
New feature?	no
Breaks BC?	no
Specs pass?	yes

I agree that $_defaultFinderClassName should be private, because it takes part in class logic. But developers should have ability to redefine Finder class if it's needed