search

php-opencloud / openstack

PHP SDK for OpenStack clouds
Apache License 2.0
221 stars 148 forks source link

Fix testing class namespaces #317

Closed peter279k closed 8 months ago

peter279k commented 3 years ago

Changed log

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 692

Totals Coverage Status
Change from base Build 691: 0.0%
Covered Lines: 1669
Relevant Lines: 1735
💛 - Coveralls
haphan commented 3 years ago

@peter279k thanks for this pr. Does it break anything or more of inconsistency issue?

peter279k commented 3 years ago

This will not break anything and it's only for testing when PHPUnit does unit tests and load namespaces autoloading.

haphan commented 3 years ago

I mean before this fix, what was not working?

peter279k commented 3 years ago

When using the refactor, it will present some test classes are not found.

And I fix them to be compatible with PSR-4 autoloader.

haphan commented 3 years ago

Let me do a quick review later this week

k0ka commented 8 months ago

After 3 years of quick review we were able to merge it =). https://github.com/php-opencloud/openstack/pull/383 Thank you for your PR.