php-opencloud / openstack

PHP SDK for OpenStack clouds
Apache License 2.0
221 stars 148 forks source link

[WIP] Application credentials #336

Closed smarcet closed 8 months ago

smarcet commented 3 years ago

this feature branch adds the

application credentials to identity api

depicted here

https://docs.openstack.org/keystone/latest/user/application_credentials.html

smarcet commented 3 years ago

guys greetings i work for the OSF i do think this feature will be really useful matter of fact we are using this lib to integration openstackid.org with swift object storage using app credentials

regards

haphan commented 3 years ago

Hi Sebastian, thanks foe your work. I will review this PR as soon as I can

On Thu, 5 Aug 2021 at 10:31 PM, sebastian marcet @.***> wrote:

guys greetings i work for the OSF i do think this feature will be really useful matter of fact we are using this lib to integration openstackid.org with swift object storage using app credentials

regards

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/php-opencloud/openstack/pull/336#issuecomment-893507280, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGARMQ65THJ35I53NKUHJTT3KODPANCNFSM5BT7EN4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

haphan commented 3 years ago

I think it would be very useful for this SDK to support application credentials (added since Openstack 3.10 Queen).

Having said that, we probably want to do it in a systematic way; meaning to cover (1) the Application credential API as well as (2) the login flow.

@smarcet Are you able to work on it?

smarcet commented 3 years ago

@haphan as far i understand PR covers (2) [login flow] i do think that (1) could be covered on a second PR regards

drzraf commented 2 years ago

Some additional tweaks: https://github.com/drzraf/openstack/commit/b5ead02547391743a745c30e06537602441c55b2

  1. application credentials (at least mine) can not request a scope, so the payload sent to /tokens must be modified according to the authentication method
  2. Fix an error message regarding the supported authentication methods.
drzraf commented 2 years ago

@smarcet

martijnve commented 9 months ago

We have tested this MR in our application and would very much like this to be in the mainline. Is there anything we can do to assist in this feature getting merged?

smarcet commented 9 months ago

@martijnve hello! i will try to make some time before EOY to review the comments

k0ka commented 9 months ago

Hello,

I haven't checked it yet. I hope I'll have some time this week. Most probably I won't merge it to the mainline without integration tests. And writing them might be quite tricky.

k0ka commented 8 months ago

Superseded by https://github.com/php-opencloud/openstack/pull/380 Released in https://github.com/php-opencloud/openstack/releases/tag/v3.5.0