php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
281 stars 21 forks source link

GH Actions: use `fail-fast` with setup-php when creating the binaries #131

Closed jrfnl closed 1 year ago

jrfnl commented 1 year ago

The recent build failure was due to the setup-php action running into a rate limit and not downloading the required version of Composer (2.2), which meant that the PHAR ended up being build with Composer 2.4.

The setup-php action runner defaults to showing these type errors in the logs, but not stopping the workflow run.

For the creation of the binary it is really important that the correct Composer version is used as otherwise the PHAR file won't be compatible with PHP 5.3 - 5.5.

So, specifically for those jobs, I'm adding the fail-fast option to setup-php to fail the build if the action runner ran into any errors.

Ref: https://github.com/shivammathur/setup-php#fail-fast-optional

grogy commented 1 year ago

Thank you, merged :-)