php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
287 stars 21 forks source link

Docker CLI / image option #133

Closed pentatonicfunk closed 1 year ago

pentatonicfunk commented 1 year ago

To allow to integrate it with CI directly, without installing it as dependency similar to this: https://github.com/overtrue/phplint#docker-cli

so we can use it this way

          - step:
              image: overtrue/phplint:8.1
              name: PHP Linting parallel
              script:
                - /root/.composer/vendor/bin/phplint ./
jrfnl commented 1 year ago

@pentatonicfunk You can already get PHP Parallel Lint set up via the setup-php action, so I'm not sure what the point would be of adding more maintenance overhead ?

- name: Setup PHP without composer
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.2'
    tools: parallel-lint
- name: Run lint
  run: parallel-lint .
pentatonicfunk commented 1 year ago

do we have reference to achieve the same thing but on Gitlab / Bitbucket ?

pentatonicfunk commented 1 year ago

i guess at least i can use php cli as image, and then add this parallel lint as global package, instead of project package.

yea, feel free to close this one, if it isn't worth to pursue dedicated docker / image for this

grogy commented 1 year ago

Thank you for the suggestion.

As Juliette writes, you can now use shivammathur/setup-php@v2 directly within Github which makes it easier to use.

I don't see the reason for a custom package now. Installation is simple. However, if you feel otherwise, I would welcome a merge request with a documentation edit where there will be a description for other CI tools.