search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
287 stars 21 forks source link

parallel-lint iterates directory structure even if excluded #135

Closed staabm closed 1 month ago

staabm commented 1 year ago

I was wondering that parallel-lint works thru a deep directory structure (e.g. vendor/) even though I passed --exclude vendor as a cli arg.

it seems the tools is deep iterating everything and does the filtering afterwards.

wouldn't it be way faster to ignore the excluded directories in the first place, so we don't need to scan the whole directory structure to finally decided there is nothing to lint inside?

staabm commented 1 month ago

I can no longer reproduce the slownes in the latest 1.4.x release