search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
287 stars 21 forks source link

Implement faster FilteredRecursiveDirectoryIterator #136

Closed staabm closed 1 month ago

staabm commented 1 year ago

closes https://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/135

running parallel lint in https://github.com/FriendsOfREDAXO/rexstan with vendor/bin/parallel-lint . --exclude vendor takes 0.3 seconds with this PR while it took 9 seconds before the PR

staabm commented 1 year ago

@jrfnl anything I can do to move this forward?

jrfnl commented 1 year ago

@staabm Not really. I'll try to find some time to review this over the next few weeks. That should hopefully help, but this is, in my experience, generally speaking a slow moving repo, so patience is the keyword...

staabm commented 1 year ago

Tbh I have implemented against 1.x - we need to verify it against 2.x (and see whether the speed improvements are still visible on 2.x)

staabm commented 1 year ago

let my clarify my last comment: the PR works in parallel-lint 1.x which I am currently using and it gives a decent speed boost, because without it, vendor files get linted even though I am passing --exclude vendor.

I did not verify the fix on parallel-int 2.x .. it looks like on 2.x the vendor is properly ignored even before this patch

staabm commented 1 month ago

@jrfnl we just talked about this :-)

(It might no longer be relevant)

staabm commented 1 month ago

I can no longer reproduce the slownes in the latest 1.4.x release