search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
287 stars 21 forks source link

[PHP 8.4] Fixes for implicit nullability deprecation #154

Closed Ayesh closed 7 months ago

Ayesh commented 8 months ago

Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations.

See:

jrfnl commented 8 months ago

@Ayesh Would you be okay with me updating this PR to get it into a mergable state ?

@grogy Once this patch is ready, we should merge it, cherrypick it to master and release it as soon as possible as people using PHP Parallel Lint to already check their code against PHP 8.4 will currently get failing builds due to this deprecation.

As develop and master have some differences at this time, I'll open a ticket in a moment with a proposal on how to deal with this and what's needed (in my opinion) to do a release.

Ayesh commented 8 months ago

Please feel free to update the PR. If it makes things easier/cleaner, lets just close this one. Completely trusting you hands that you will sort balance the deprecation notices and the best compatibility.

jrfnl commented 8 months ago

Please feel free to update the PR. If it makes things easier/cleaner, lets just close this one. Completely trusting you hands that you will sort balance the deprecation notices and the best compatibility.

Thanks @Ayesh ! I've just pushed an update. Let's hope the build passes ;-)

jrfnl commented 8 months ago

I've just cherrypicked the commit from PR #152 into this one to get the builds running properly. 🤞🏻

jrfnl commented 8 months ago

Test failure on PHP 8.4 looks to be related to incompatibilities in the last version of PHPUnit 9 (will likely be fixed soon), not related to this package itself.

jrfnl commented 8 months ago

I've done a test run which combines the changes from PR #152, #157 and this PR and that gets us a passing build on PHP 8.4, which confirms that this patch fixes the PHP 8.4 issue.

https://github.com/php-parallel-lint/PHP-Parallel-Lint/actions/runs/8310177747

Ayesh commented 8 months ago

This is amazing, thank you!

grogy commented 7 months ago

Thank to both, it looks great. I merge it.