search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
287 stars 21 forks source link

Ignore PHP startup errors #34

Closed jrfnl closed 4 years ago

jrfnl commented 4 years ago

Ignoring PHP startup errors completely for any PHP processes started from within the application.

Fixes #33

jrfnl commented 4 years ago

@grogy Anything I can do to move this PR forward ?

jrfnl commented 4 years ago

@grogy Any chance of this PR getting some love ?

grogy commented 4 years ago

I read previous thread https://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/33 and current I think about it is good thing in project. Maybe it make the sence.. please, take me a few days for it.

Idea - is good when tool does second thing - silence warnings?

grogy commented 4 years ago

My thinking about this change takes long. I am sorry, but I cannot merge everything that will be created in PRs.

It makes sense to me. Reason - directive display-startup-errors is for debugging and in Lint we do not need other extensions (only json, but currently PHP versions include JSON-extension).

Thank you @Seldaek for define problem and @jrfnl for implementation and kick me for resolve PR :)