search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
282 stars 21 forks source link

Add missing reflinks to changelog #57

Closed glensc closed 3 years ago

glensc commented 3 years ago

See the guide: https://keepachangelog.com/en/1.0.0/

glensc commented 3 years ago

A side topic, what you think of converting all links to reflinks? makes the file much easier to read in the editor and plain text viewer:

-- Restore php 5.3 support [#51](https://github.com/php-parallel-lint/PHP-Parallel-Lint/pull/51) from [@glensc](https://github.com/glensc).
+- Restore php 5.3 support [#51] from [@glensc].
+
+[#51]: https://github.com/php-parallel-lint/PHP-Parallel-Lint/pull/51
+[@glensc]: https://github.com/glensc

bonus is that GitHub handles need to be declared only once, not for each ocurrence.

grogy commented 3 years ago

Thank you @glensc for the fix. I will merge it.

Converting reflinks - nice, it is better. Writing in the current style is uncomfortable. Know you some tools for converting?

glensc commented 3 years ago

I tried to use some tools, but none of them did the right thing fully, so ended up reformatting manually anyway:

tried: