search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
282 stars 21 forks source link

GH Actions: set error reporting to E_ALL #65

Closed jrfnl closed 3 years ago

jrfnl commented 3 years ago

Turns out the default setting for error_reporting used by the SetupPHP action is error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT and display_errors is set to Off.

For the purposes of CI, I'd recommend running with E_ALL and display_errors=On to ensure all PHP notices are shown.

Note: as the CI run isn't failing on the deprecation notice as addressed in #64, this PR exposes a shortage of tests, which should be addressed, though this is outside the scope of this PR.

jrfnl commented 3 years ago

Rebased without changes just to check the current status against PHP 8.1.

grogy commented 3 years ago

Thank you, it makes sense

glensc commented 2 years ago

this is attributed as @glensc in changelog:

GH Actions: set error reporting to E_ALL #65 from @glensc.

grogy commented 2 years ago

@glensc fixed, thank you https://github.com/php-parallel-lint/PHP-Parallel-Lint/blob/345ec0f6924bff282ef6bfd13b29b32949ce7042/CHANGELOG.md