search

php-parallel-lint / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
287 stars 21 forks source link

ErrorFormatter: support PHP Console Highlighter 1.0.0 #92

Closed jrfnl closed 2 years ago

jrfnl commented 2 years ago

PHP Console Highlighter 1.0.0 has just been released.

This PR adds cross-version support for both PHP Console Highlighter < 1.0.0 and 1.0.0+ to PHP Parallel Lint, which allows people to update the Highlighter dependency to the latest version.

Includes changelog entry to allow this PR to still be included in the 1.3.2 release.

Ref: https://github.com/php-parallel-lint/PHP-Console-Highlighter/releases/tag/v1.0.0

jrfnl commented 2 years ago

@grogy Would be great if this PR could be merged so 1.3.2 can be released. 🙏🏻 Thanks!

grogy commented 2 years ago

Thank you, it looks good :-)

jrfnl commented 2 years ago

Thanks @grogy. You okay with me tagging 1.3.2 now ?

grogy commented 2 years ago

Yes, I agree. You will create "intro" message for new version? When yes, than I suggest

New version support PHP 8.1, is again tested against PHP 5.3 and we welcome @jrfnl as maintainer.

https://github.com/php-parallel-lint/PHP-Parallel-Lint/compare/v1.3.1...HEAD

jrfnl commented 2 years ago

What do you mean by intro message ? And how do you normally do this ?

I thought it was a case of tagging the last commit, pushing the tag to GH, then the release workflow will create the Draft release and I add the changelog to it from the other PR ?

grogy commented 2 years ago

I mean one sentence before contain from changelog.

Example:

New version support PHP 8.1, is again tested against PHP 5.3 and we welcome @jrfnl as maintainer.

### Added

- Support for PHP Console Highlighter 1.0.0, which comes with PHP Console Color 1.0.1, [#92] from [@jrfnl].

### Fixed

- Bug fix: make Phar file run independently of project under scan [#63] from [@jrfnl], fixes [#61].
- Bug fix: checkstyle report could contain invalid XML due to insufficient output escaping [#73] from [@gmazzap], fixes [#72].
- Fix Phar building [#70] from [@jrfnl]. This fixes PHP 8.1 compatibility for the Phar file.
- Documentation fix: the `--show-deprecated` option was missing in both the README as well as the CLI `help` [#84] from [@jrfnl], fixes [#81] reported by [@stronk7].

### Changed

- README: updated information about PHAR availability [#77] from [@jrfnl].
.......
jrfnl commented 2 years ago

Ah, in the release notes ? Or do you use annotated tags ?

jrfnl commented 2 years ago

I've used an annotated tag now. Fingers crossed I've done it correctly.

grogy commented 2 years ago

Perfect :rocket: