search

php-pds / skeleton

Standard PHP package skeleton.
Creative Commons Attribution Share Alike 4.0 International
2.3k stars 167 forks source link

Generator #25

Closed afilina closed 7 years ago

afilina commented 7 years ago

Refactored validator and added package generator cli tool. #23

pmjones commented 7 years ago

A couple of things stand out to me:

  1. Let's use Pds\ instead of PDS\.

  2. Under PSR-4, the directories can be collapsed for the namespace prefix, so the source code can be directly in the src/ directory, and don't need to be in src/Pds/Skeleton/. Can you move those files, and update the composer.json in line with that ("psr-4": { "PDS\\Skeleton\\": "src/" }) ?

afilina commented 7 years ago

@pmjones I made the changes.

pmjones commented 7 years ago

I see some minor issues but no blockers. Thanks!

afilina commented 7 years ago

Let me know how I can improve it.