search

php-pds / skeleton

Standard PHP package skeleton.
Creative Commons Attribution Share Alike 4.0 International
2.32k stars 167 forks source link

Exit with an evaluable return code #34

Closed raphaelstolt closed 7 years ago

raphaelstolt commented 7 years ago

Validate command can now be evaluated.

pmjones commented 7 years ago

You're right; there should be an evaluable exit. But the place to put it is not in the execute() method; instead, it should be in the bin/pds-skeleton script. If you can, modify this PR (or submit a new PR) so that bin/pds-skeleton takes the return from the execute() method, and then uses that for an exit code. Make sense?

raphaelstolt commented 7 years ago

Done via 7e1a096bc6fb399ccd8ad9961ef62816c5b3b163.

pmjones commented 7 years ago

@raphaelstolt right on!

@afilina -- please review, if you have the time and inclination.

afilina commented 7 years ago

Read code: ✓ Executed tests: ✓ Executed code: ✓