search

php-perfect / ddev-intellij-plugin

DDEV Tool Integration for IntelliJ IDEA
https://plugins.jetbrains.com/plugin/18813-ddev-integration
BSD 3-Clause "New" or "Revised" License
109 stars 15 forks source link

Change autoconfiguration of node.js binary path to node #358

Closed AkibaAT closed 1 month ago

AkibaAT commented 1 month ago

The Problem/Issue/Bug:

The node.js binary path is incorrect for DDEV version 1.23.4, where the path changed from /usr/bin/node to /usr/local/bin/node.

How this PR Solves the Problem:

This change sets the node binary without an absolute path. That way, functionality is ensured across DDEV versions without having to check the currently running version. This setup also matches the JetBrains documentation examples of setting up node.js docker compose remote interpreter.

Manual Testing Instructions:

Remove the node.js DDEV connection Close and reopen the project Check the configuration, it should only refer to "node" as path Test node functionality

Related Issue Link(s):

353

nico-loeber commented 1 month ago

I prefer absolute paths whenever possible because often the PATH environment variable isn't populated as expected when running script in the IDE. But if it works well, I'm fine with it.

rfay commented 1 month ago

If you're using any kind of exec or ssh then /usr/bin and /usr/local/bin will always be in the PATH unless something really unusual is going on.