Auto config breaks if project contains period `.`

IanEdington commented 5 days ago

Is there an existing issue for this?

[X] I have searched the existing issues

Are you sure that this bug is related to this DDEV Integration Plugin?

[X] I am sure

Enter your error report ID (If available)

No response

Describe the bug

I have a project called gpo.ca (the URL of the site I'm working on) in ddev is fine with me calling it that and sanitizes the name where necessary.

I installed this plugin to use the ddev interpreter in phpstorm. The auto load was awesome but appears not to have done the same sanitization.

I was receiving an error Failed to start docker-compose service, start it in a command line and retry and found that the issue was with COMPOSE_PROJECT_NAME=ddev-secure.gpo.ca.

In the ./.ddev/.ddev-docker-compose-full.yaml file the project name is ddev-securegpoca

Changing COMPOSE_PROJECT_NAME to ddev-securegpoca fixed my issue.

Steps to reproduce

No response

Additional context

No response

rfay commented 4 days ago

docker-compose project names cannot contain a dot. DDEV removes the dot for compose project names. So COMPOSE_PROJECT_NAME must not have a dot and should be lower case.

This was all discussed in

https://github.com/php-perfect/ddev-intellij-plugin/issues/97

for about 2 years. I guess maybe we have to look again @nico-loeber @AkibaAT ?

IanEdington commented 4 days ago

Thanks for the speedy reply! And nice to meet you.

My understanding is that the referenced issue is about removing the envvar. From what I've read on some IntelliJ tickets, it's still needed.

The fix for me was to change the value of the envvar not remove it. I'll try removing it though and see if that also works.

rfay commented 4 days ago

We decided that removing COMPOSE_PROJECT_NAME broke PhpStorm, because PhpStorm used it for an additional reason.

But I thought we had solved the "dot" problem elsewhere in PhpStorm.

php-perfect / ddev-intellij-plugin