php-pm / php-pm-httpkernel

HttpKernel adapter for use of Symfony and Laravel frameworks with PHP-PM
MIT License
246 stars 72 forks source link

httpkernel-adapter/Bootstraps/Laravel.php:165 Exception #142

Closed seateng closed 6 years ago

seateng commented 6 years ago

The exception was: ArgumentCountError: ReflectionMethod::__construct() expects exactly 1 parameter, 2 given in /Users/seateng/Projects/Seateng/labs/laravel/laravel_ppm/vendor/php-pm/httpkernel-adapter/Bootstraps/Laravel.php:165

$method = new \ReflectionMethod(get_class($this->app), ['name' => 'register']); to: $method = new \ReflectionMethod(get_class($this->app), 'register');

Running!

andig commented 6 years ago

I‘m confused- this class has 2 constructors? See http://php.net/manual/en/reflectionmethod.construct.php

marcj commented 6 years ago

Yeah, but it does not have (string, array), so we need to call it via (string, string).

andig commented 6 years ago

Fair, but that should not cause the error message above? I‘ll give it another try...

snellingio commented 5 years ago

I can confirm this is an issue on my end. Will look at making a PR this week. Haven't run into this issue until starting a new project with the latest version of php & Laravel

snellingio commented 5 years ago

Already been fixed. Sorry!

snellingio commented 5 years ago

If you run into this issue: the current tagged versions do not have this fix. Set php-pm/httpkernel-adapter to dev-master and you're good to go!

andig commented 5 years ago

Tagged 1.0.6 to take care