search

php-pm / php-pm-httpkernel

HttpKernel adapter for use of Symfony and Laravel frameworks with PHP-PM
MIT License
246 stars 72 forks source link

Fix Webpack Encore Bundle EntrypointLookup reset #153

Closed fionera closed 4 years ago

andig commented 5 years ago

Could you take a look at the related and unrelated travis exceptions?

fionera commented 5 years ago

Its a bug in PHPStan... https://github.com/phpstan/phpstan/issues/1871

andig commented 5 years ago

Yeah, thought so after looking at the function definition. You could add an exception for the time being.

fionera commented 5 years ago

Sorry for the ton of commits, when merging just make a Squash merge :)

fionera commented 5 years ago

A Exception in the .phpstan.neon will not help :/ PHPStan says this then... "Error message cannot be ignored, use excludes_analyse instead.". I would have to exclude the whole Bootstrap file from the checks.

andig commented 5 years ago

Waiting for bug in phpstan to be fixed then?

fionera commented 5 years ago

Currently yes since i didnt got the ignore to work

acasademont commented 4 years ago

The webpack bundle afaik should be able to reset itself as of version 1.7.2, correct? I believe this is not needed anymore and the resets can be removed?

acasademont commented 4 years ago

Relevant commit is here https://github.com/symfony/webpack-encore-bundle/commit/3a3eac35c83038f5dd08d584480e82f03aedcf7e

fionera commented 4 years ago

I didnt check it yet since I currently just patch this pr into my vendor folder. Will look if it works now without it.

fionera commented 4 years ago

I just tested it in my System and there it works :) So this isnt needed anymore ^^