search

php-runtime / runtime

A home for runtimes.
MIT License
404 stars 32 forks source link

[FrankenPHP] Relax php requirement - allow 8.0 #129

Closed chalasr closed 2 years ago

chalasr commented 2 years ago

Allows playing with https://github.com/dunglas/frankenphp-demo with PHP 8.1 installed locally and without need to tweak the README instructions. Otherwise:

Screenshot 2022-10-16 at 15 38 36

Let's revisit this only once php 8.2 stable gets released.

chalasr commented 2 years ago

Lowered to >=8.0 as it makes the CI happy and requires zero code change.

dunglas commented 2 years ago

I'm not sure it's worth it because FrankenPHP doesn't work at all with PHP <8.2 (and only with a patched version of 8.2).

If you want to test locally on 8.x before running the code in FrankenPHP, you can do composer install --ignore-platform-req=php

chalasr commented 2 years ago

and only with a patched version of 8.2

Isn't it embedded in FrankenPHP anyway? I hesitated to rather add the ignore-platform-req flag to the demo's install instructions but realized that the PHP on which FrankenPHP runs doesn't matter for people using this runtime (just trying to improve the checkout experience while it's hot so that you get more segfaults to fix! :p)

dunglas commented 2 years ago

Works for me!

chalasr commented 2 years ago

A tag would be much appreciated when you have a chance 🙏

Nyholm commented 2 years ago

https://github.com/php-runtime/frankenphp-symfony/releases/tag/0.1.1

chalasr commented 2 years ago

Thank you!