search

php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

Initial SplitItem + CheckableItem support #189

Closed jtreminio closed 4 years ago

jtreminio commented 4 years ago

Not yet ready to merge, pending unit tests and feedback.

codecov-io commented 4 years ago

Codecov Report

Merging #189 into master will decrease coverage by 0.14%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
- Coverage     93.19%   93.05%   -0.15%     
- Complexity      486      491       +5     
============================================
  Files            27       27              
  Lines          1470     1483      +13     
============================================
+ Hits           1370     1380      +10     
- Misses          100      103       +3
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/CheckableItem.php 86.66% <ø> (ø) 19 <0> (ø) :arrow_down:
src/Builder/SplitItemBuilder.php 76.31% <100%> (+2.03%) 11 <1> (+1) :arrow_up:
src/MenuItem/SplitItem.php 97.67% <50%> (-2.33%) 45 <0> (+2)
src/Builder/CliMenuBuilder.php 84.07% <0%> (+0.4%) 67% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c4db90...d25a1b3. Read the comment docs.

AydinHassan commented 4 years ago

Looks good to me - please add some tests and documentation 👍

AydinHassan commented 4 years ago

Thank you @jtreminio !