search

php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

Removes $callback->bindTo() #192

Closed jtreminio closed 4 years ago

jtreminio commented 4 years ago

Closes #191

codecov-io commented 4 years ago

Codecov Report

Merging #192 into master will decrease coverage by <.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
- Coverage     93.19%   93.18%   -0.01%     
  Complexity      486      486              
============================================
  Files            27       27              
  Lines          1470     1468       -2     
============================================
- Hits           1370     1368       -2     
  Misses          100      100
Impacted Files Coverage Δ Complexity Δ
src/Builder/CliMenuBuilder.php 83.58% <ø> (-0.09%) 65 <0> (ø)
src/Builder/SplitItemBuilder.php 73.52% <ø> (-0.76%) 10 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c4db90...240a745. Read the comment docs.

AydinHassan commented 4 years ago

Let's go with this. Thanks @jtreminio .