php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

Checkbox + Radio item-level styling #204

Closed jtreminio closed 4 years ago

jtreminio commented 4 years ago

Related to #203 and #200

This does not fix the nested-style issue from #201

codecov-io commented 4 years ago

Codecov Report

Merging #204 into master will increase coverage by 0.07%. The diff coverage is 95.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     93.91%   93.99%   +0.07%     
- Complexity      516      530      +14     
============================================
  Files            29       32       +3     
  Lines          1561     1648      +87     
============================================
+ Hits           1466     1549      +83     
- Misses           95       99       +4
Impacted Files Coverage Δ Complexity Δ
src/MenuStyle.php 96.99% <ø> (-0.29%) 70 <0> (-8)
src/Style/CheckboxStyle.php 100% <100%> (ø) 3 <3> (?)
src/Style/RadioStyle.php 100% <100%> (ø) 3 <3> (?)
src/Builder/SplitItemBuilder.php 83.92% <100%> (+6.42%) 14 <3> (+2) :arrow_up:
src/CliMenu.php 95.25% <100%> (+0.2%) 113 <4> (+4) :arrow_up:
src/MenuItem/RadioItem.php 100% <100%> (ø) 11 <7> (+1) :arrow_up:
src/MenuItem/ToggableTrait.php 100% <100%> (ø) 10 <6> (-1) :arrow_down:
src/MenuItem/CheckboxItem.php 100% <100%> (ø) 10 <10> (?)
src/MenuItem/SplitItem.php 100% <100%> (ø) 45 <0> (-2) :arrow_down:
src/Builder/CliMenuBuilder.php 82.72% <77.77%> (+0.99%) 70 <3> (ø) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9e6a34...ed13965. Read the comment docs.

AydinHassan commented 4 years ago

Could you maybe rebase off master? I just cherry-picked the rename into master hoping it would just remove it from the PR but now it is conflicting 🙈

AydinHassan commented 4 years ago

I've open #205 without the checkbox rename