search

php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

Checkbox + Radio item-level styling #205

Closed AydinHassan closed 4 years ago

AydinHassan commented 4 years ago

204 without checkbox rename

Related to #203 and #200

This does not fix the nested-style issue from #201

codecov-io commented 4 years ago

Codecov Report

Merging #205 into master will decrease coverage by 1.43%. The diff coverage is 82.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
- Coverage     93.91%   92.48%   -1.44%     
- Complexity      516      559      +43     
============================================
  Files            29       30       +1     
  Lines          1561     1689     +128     
============================================
+ Hits           1466     1562      +96     
- Misses           95      127      +32
Impacted Files Coverage Δ Complexity Δ
src/MenuStyle.php 96.99% <ø> (-0.29%) 70 <0> (-8)
src/MenuItem/RadioItem.php 100% <100%> (ø) 21 <11> (+11) :arrow_up:
src/CliMenu.php 95.25% <100%> (+0.2%) 113 <4> (+4) :arrow_up:
src/MenuItem/SplitItem.php 100% <100%> (ø) 45 <0> (-2) :arrow_down:
src/Builder/CliMenuBuilder.php 78.76% <50%> (-2.97%) 76 <6> (+6)
src/Builder/SplitItemBuilder.php 70.31% <61.53%> (-7.19%) 20 <6> (+8)
src/MenuItem/CheckboxItem.php 92.72% <87.87%> (-7.28%) 20 <11> (+11)
src/Style/CheckboxStyle.php 88.57% <88.57%> (ø) 12 <12> (?)
src/Style/RadioStyle.php 88.57% <88.57%> (ø) 12 <12> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c72b588...4ea4242. Read the comment docs.

jtreminio commented 4 years ago

Please review and merge #210 before this PR.

It is going to be required for this process to work properly, and since there have been a ton of changes and I messed up on the SplitItem styling (https://github.com/php-school/cli-menu/pull/205#discussion_r360161597) it's probably best if I create a new PR without all the changes.

AydinHassan commented 4 years ago

@jtreminio #210 is merged now. Thank you. I think these changes should be a lot simpler now.

jtreminio commented 4 years ago

Competing PR at #211