search

php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

SplitItemBuilder should reference menu styles #208

Closed jtreminio closed 4 years ago

jtreminio commented 4 years ago

Related to #205

codecov-io commented 4 years ago

Codecov Report

Merging #208 into item-style will decrease coverage by 0.25%. The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff                @@
##             item-style     #208      +/-   ##
================================================
- Coverage         92.73%   92.48%   -0.26%     
+ Complexity          561      559       -2     
================================================
  Files                30       30              
  Lines              1693     1689       -4     
================================================
- Hits               1570     1562       -8     
- Misses              123      127       +4
Impacted Files Coverage Δ Complexity Δ
src/Builder/CliMenuBuilder.php 78.76% <100%> (-0.19%) 76 <0> (-2)
src/Builder/SplitItemBuilder.php 70.31% <50%> (-6.97%) 20 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da43609...0f1db5f. Read the comment docs.

AydinHassan commented 4 years ago

OK it works but I can't wrap my head around it. It's getting late here now anyway, need to sleep.