search

php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

Don't append two \n in CliMenu::draw() #229

Closed jtreminio closed 4 years ago

jtreminio commented 4 years ago

Howdy.

draw() calls newLine() twice: https://github.com/php-school/cli-menu/blob/master/src/CliMenu.php#L530

If we're trying to build an app that fits within "standard" 24x80 the new lines take up quite a bit of space:

image

vs not including them:

image

There's no option to remove this. Thoughts on removing or adding a default-on flag that can be disabled?

AydinHassan commented 4 years ago

I don't see why not, would you do it for both top and bottom, or just bottom?

AydinHassan commented 4 years ago

@jtreminio planning on releasing 4.0.0 in the next couple of days if there's anything you want to add :)