feat(password): Make password having custom length

[samijnih]

Why

Hello :)

I'm currently using your api to make a php cli menu for my app. I've been facing a problem when I wanted to make a user registration area.

• I ask to users to type their passwords
  • the password length is hard-coded in the code and it's 16 characters length
  • I don't want to give a closure to custom validator method because I think it's too much effort

So the aim of my pull request is to allow developers like me to call a setter in order to give another length. Of course, I made it backward-compatible so the previous value is a default value if the new method is not called.

Description

• fix phpdoc type error in password unit test
• add new internal property about password length with default value int "16"
• replace hard coded password length comparison with that internal property
• add a new setter for a custom password length
• add missing ext-mbstring to composer.json
• add setValidator to Input interface
• add tests in PasswordTest

[codecov-io]

Codecov Report

Merging #235 into master will increase coverage by <.01%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
+ Coverage     92.86%   92.87%   +<.01%     
- Complexity      622      623       +1     
============================================
  Files            37       37              
  Lines          1864     1866       +2     
============================================
+ Hits           1731     1733       +2     
  Misses          133      133

Impacted Files	Coverage Δ	Complexity Δ
src/Input/Password.php	100% <100%> (ø)	15 <1> (+1)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1acf6fc...6f30f2d. Read the comment docs.

[AydinHassan]

Looks good to me! Only one thing, adding the method setValidator to the interface would be a BC break so I'm not sure we want to do that.

[samijnih]

Looks good to me! Only one thing, adding the method setValidator to the interface would be a BC break so I'm not sure we want to do that.

Hey :)

Are you sure about that? because there are only 3 classes which implement the Input interface:

• Password
• Text
• Number

There are all located in namespace PhpSchool\CliMenu\Input.

Also, even if people have extended these classes, the setValidator is already public and inside all the classes. I don't see how it could make a breaking change. May you give me more details? :)

[AydinHassan]

hey @samijnih if any body is implementing the interface to create their own inputs they might not have the setValidator method. If we add the method to the interface then their custom inputs will break.

[samijnih]

hey @samijnih if any body is implementing the interface to create their own inputs they might not have the setValidator method. If we add the method to the interface then their custom inputs will break.

You're right, I'm gonna update it

[AydinHassan]

thank you @samijnih !

[samijnih]

You're welcome!