search

php-school / cli-menu

🖥 Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.
http://www.phpschool.io
MIT License
1.94k stars 106 forks source link

Fixed problem with package installation on Windows #245

Closed Igoriankrg closed 3 years ago

Igoriankrg commented 3 years ago

This update needs to prevent usage "composer install --ignore-platform-reqs" everytime on Windows (not posix system). Source of idea - https://stackoverflow.com/a/52778992

AydinHassan commented 3 years ago

@Igoriankrg we're pretty sure it doesn't work on windows. Have you been using it and found any issues? It has been a long time since we tried.

AydinHassan commented 3 years ago

Just to be clear, we do use posix functions, so the requirement is necessary. The library simply won't work without them.

Igoriankrg commented 3 years ago

I agree with it (i think nobody use Windows to host their applications), but for developers on Windows it would be nice convenience update.

AydinHassan commented 3 years ago

@Igoriankrg we use posix functions. See: https://github.com/php-school/terminal/blob/master/src/IO/ResourceInputStream.php#L45 which is a direct requirement of php-school/cli-menu. This change would allow to install cli-menu on an environment where the code does not function correctly.

Igoriankrg commented 3 years ago

I cannot image more suitable way out. So "composer install --ignore-platform-reqs" for Windows users is best solution to know about the code does not function correctly on this environment.