Updated Confirmation Dialog

[ccsliinc]

Please look over the proposed changes to make the dialog box cancellable. The proposed changes will not break any existing code. The method remains the same with an additional argument, additional example added to source as well.

[AydinHassan]

Hi @ccsliinc thanks for the contribution - I've been afk for a few days, will get to this soon

[codecov-commenter]

Codecov Report

Merging #248 (42a6491) into master (d5a96a5) will increase coverage by 0.30%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
+ Coverage     93.08%   93.38%   +0.30%     
- Complexity      634      659      +25     
============================================
  Files            37       38       +1     
  Lines          1922     1994      +72     
============================================
+ Hits           1789     1862      +73     
+ Misses          133      132       -1     

Impacted Files	Coverage Δ
src/CliMenu.php	94.40% <100.00%> (+0.10%)	:arrow_up:
src/Dialogue/CancellableConfirm.php	100.00% <100.00%> (ø)
src/Dialogue/Dialogue.php	90.00% <100.00%> (ø)
src/Input/InputIO.php	96.92% <100.00%> (+0.02%)	:arrow_up:
src/MenuStyle.php	98.96% <100.00%> (+0.01%)	:arrow_up:
src/Style/Locator.php	100.00% <0.00%> (+2.85%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a96a5...42a6491. Read the comment docs.

[AydinHassan]

Hi @ccsliinc - I've taken a look and while it mostly looks good I'm concerned about using the existing Confirm class. I'd prefer, as noted in the previous PR, that we use a separate class. CancellableConfirm would be fine.

[ccsliinc]

ok i will fix and resubmit, give me a couple days.

[AydinHassan]

Sure, no rush!

[ccsliinc]

I uploaded a fixed PR.

[AydinHassan]

Thanks for the contribution @ccsliinc !