search

php-school / learn-you-php

🏆 Learn You PHP! - An introduction to PHP's core features: i/o, http, arrays, exceptions and so on.
http://www.phpschool.io/
MIT License
319 stars 36 forks source link

WIP - HTTP Upper Caserer #12

Closed AydinHassan closed 8 years ago

AydinHassan commented 8 years ago

Yo @mikeymike

I'm not really sure about this exercise, it's from learnyounode, but it's a bit boring/easy/useless

what do you think?

I didn't convert the solution yet

And it seems it doesn't actually do the same as the node one, node one sends multiple words via the stream and basically waits for data before mapping it, maybe I can do that instead of sending one word. Doesn't really seem the PHP way tho

codecov-io commented 8 years ago

Current coverage is 89.32%

Merging #12 into master will decrease coverage by -10.68% as of e09deb7

@@            master     #12   diff @@
======================================
  Files            7       8     +1
  Stmts          184     206    +22
  Branches         0       0       
  Methods         57      64     +7
======================================
  Hit            184     184       
  Partial          0       0       
- Missed           0      22    +22

Review entire Coverage Diff as of e09deb7

Powered by Codecov. Updated on successful CI builds.

AydinHassan commented 8 years ago

shutup @codecov-io

mikeymike commented 8 years ago

@AydinHassan yeah I agree this looks like it's more focused towards streams and tbh I reckon streams could probably do with a whole workshop, it's not really something I'd expect to be handling in the first workshop anyway.