php-school / learn-you-php

🏆 Learn You PHP! - An introduction to PHP's core features: i/o, http, arrays, exceptions and so on.
http://www.phpschool.io/
MIT License
319 stars 36 forks source link

Add first Composer exercise: Dependency Heaven #15

Closed mikeymike closed 8 years ago

mikeymike commented 8 years ago

@AydinHassan Let me know what you think dude.

Only things I'm questioning atm are

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #15 into master will not affect coverage as of 73bd7d3

@@            master     #15   diff @@
======================================
  Files           11      12     +1
  Stmts          258     300    +42
  Branches         0       0       
  Methods         56      62     +6
======================================
+ Hit            258     300    +42
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 73bd7d3

Powered by Codecov. Updated on successful CI builds.

mikeymike commented 8 years ago

damn @codecov-io is rapid!!!

AydinHassan commented 8 years ago

Sweet! Will check this out in the next few days dude, it is basically christmas today in Austria! Woooooo

mikeymike commented 8 years ago

No rush dude, have a great Christmas 😎❤

AydinHassan commented 8 years ago

I prefer POST. Leave the locker and when we need it next, we can abstract it. As long as we can install workshops without lowering minimum stability, then it's cool. Can you test if that is possible?

AydinHassan commented 8 years ago

looks great BTW :D

mikeymike commented 8 years ago

Hmmm just realised dude, might need to make an alteration to the Workshop anyway to run a composer install if the solution has composer. Unless of course we add the vendor directory of solutions into the project.

AydinHassan commented 8 years ago

@mikeymike eugh that is annoying. What do you think is the best solution?

mikeymike commented 8 years ago

the easy way would be to include dependencies in the workshop repos, but I can see that potentially getting a bit annoying later.

I can imagine running composer install on the exercises could also be painful though as we all know Composer isn't the fastest of things so adding time on an exercise verify might piss the end user off. Although it would only have to run once, so maybe this could be on first run ? ¯(ツ)

AydinHassan commented 8 years ago

I'm cool with just bundling them, easiest solution right? we won't be including that much anayway

mikeymike commented 8 years ago

Yeah it is, I'm just thinking future workshops but we can handle it later if needed so I'll bundle them here On 27 Dec 2015 7:11 p.m., "Aydin Hassan" notifications@github.com wrote:

I'm cool with just bundling them, easiest solution right? we won't be including that much anayway

— Reply to this email directly or view it on GitHub https://github.com/php-school/learn-you-php/pull/15#issuecomment-167436566 .