Closed mikeymike closed 8 years ago
100.00%
Merging #15 into master will not affect coverage as of
73bd7d3
@@ master #15 diff @@
======================================
Files 11 12 +1
Stmts 258 300 +42
Branches 0 0
Methods 56 62 +6
======================================
+ Hit 258 300 +42
Partial 0 0
Missed 0 0
Review entire Coverage Diff as of
73bd7d3
Powered by Codecov. Updated on successful CI builds.
damn @codecov-io is rapid!!!
Sweet! Will check this out in the next few days dude, it is basically christmas today in Austria! Woooooo
No rush dude, have a great Christmas 😎❤
I prefer POST. Leave the locker and when we need it next, we can abstract it. As long as we can install workshops without lowering minimum stability, then it's cool. Can you test if that is possible?
looks great BTW :D
Hmmm just realised dude, might need to make an alteration to the Workshop anyway to run a composer install
if the solution has composer. Unless of course we add the vendor directory of solutions into the project.
@mikeymike eugh that is annoying. What do you think is the best solution?
the easy way would be to include dependencies in the workshop repos, but I can see that potentially getting a bit annoying later.
I can imagine running composer install
on the exercises could also be painful though as we all know Composer isn't the fastest of things so adding time on an exercise verify might piss the end user off. Although it would only have to run once, so maybe this could be on first run ? ¯(ツ)/¯
I'm cool with just bundling them, easiest solution right? we won't be including that much anayway
Yeah it is, I'm just thinking future workshops but we can handle it later if needed so I'll bundle them here On 27 Dec 2015 7:11 p.m., "Aydin Hassan" notifications@github.com wrote:
I'm cool with just bundling them, easiest solution right? we won't be including that much anayway
— Reply to this email directly or view it on GitHub https://github.com/php-school/learn-you-php/pull/15#issuecomment-167436566 .
@AydinHassan Let me know what you think dude.
Only things I'm questioning atm are
@dev
but looks like that's unavoidable at the momentPOST
, did it as an experiment at first but thinking about it in a real world usage these would all beGET
requests. What do you think?