search

php-school / learn-you-php

🏆 Learn You PHP! - An introduction to PHP's core features: i/o, http, arrays, exceptions and so on.
http://www.phpschool.io/
MIT License
319 stars 36 forks source link

Fix unixtime response in http-json-api solution #56

Closed jacktonkin closed 8 years ago

jacktonkin commented 8 years ago

The solution always returns {"unixtime": "000000"} because of incorrect DateTime format.

Replace 'u' for microseconds with 'U' for unix time.

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #56 into master will not affect coverage as of 2dd4f79

@@            master     #56   diff @@
======================================
  Files           12      12       
  Stmts          342     312    -30
  Branches         0       0       
  Methods         81      81       
======================================
- Hit            342     312    -30
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 2dd4f79

Powered by Codecov. Updated on successful CI builds.

AydinHassan commented 8 years ago

Thanks! This makes me think these unit tests are not good enough here and we actually need to test the output.