search

php-school / learn-you-php

🏆 Learn You PHP! - An introduction to PHP's core features: i/o, http, arrays, exceptions and so on.
http://www.phpschool.io/
MIT License
319 stars 36 forks source link

Add docker support #74

Closed mikeymike closed 7 years ago

mikeymike commented 7 years ago

Okay so this is my initial thought process on providing docker as the main method of running workshops.

  1. Each workshop will have to have a docker image and a compose file.
  2. Require new ENV var on host, PHPSCHOOL_CODE_DIR
    • This is key to allow us to mount the files into the container and run from 3rd party 😉
  3. We just run docker-compose up -d which will spin up all required containers for workshop
    • Note if $PHPSCHOOL_CODE_DIR/learnyouphp doesn't exist it should be created by docker for us 👌
  4. Profit from cross platform, highly customisable environments 🙌

It's an incredibly simple approach that I think will work a treat for us

codecov-io commented 7 years ago

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         319    350   +31     
=====================================
+ Hits          319    350   +31
Impacted Files Coverage Δ
src/Exercise/DependencyHeaven.php 100% <0%> (ø) :arrow_up:
src/Exercise/ConcernedAboutSeparation.php 100% <0%> (ø) :arrow_up:
src/Exercise/ArrayWeGo.php 100% <0%> (ø) :arrow_up:
src/Exercise/TimeServer.php 100% <0%> (ø) :arrow_up:
src/Exercise/MyFirstIo.php 100% <0%> (ø) :arrow_up:
src/Exercise/DatabaseRead.php 100% <0%> (ø) :arrow_up:
src/Exercise/BabySteps.php 100% <0%> (ø) :arrow_up:
src/Exercise/FilteredLs.php 100% <0%> (ø) :arrow_up:
src/Exercise/ExceptionalCoding.php 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d97713...6a4d71b. Read the comment docs.

mikeymike commented 7 years ago

@AydinHassan Also went to the effort of creating a nice welcome message for users so they know how to get started 👍