search

php-school / learn-you-php

🏆 Learn You PHP! - An introduction to PHP's core features: i/o, http, arrays, exceptions and so on.
http://www.phpschool.io/
MIT License
319 stars 36 forks source link

HTTP JSON API exercise #8

Closed AydinHassan closed 8 years ago

AydinHassan commented 8 years ago

Yo @mikeymike, give this a blast when you get some time :)

codecov-io commented 8 years ago

Current coverage is 87.89%

Merging #8 into master will decrease coverage by -12.11% as of b817c70

@@            master      #8   diff @@
======================================
  Files            6       7     +1
  Stmts          167     190    +23
  Branches         0       0       
  Methods         51      57     +6
======================================
  Hit            167     167       
  Partial          0       0       
- Missed           0      23    +23

Review entire Coverage Diff as of b817c70

Powered by Codecov. Updated on successful CI builds.

mikeymike commented 8 years ago

Looks good man. Would prefer the tests to be more split but doesn't bother me that much.

Also according to codecov it's not covering the exercise o_0

AydinHassan commented 8 years ago

I mean actually check out the exercise and have a play, see what you think :)

AydinHassan commented 8 years ago

The code is definitely covered, codecov is being lame. I really don't see the point to split out the tests. I see different test methods as testing different permutations based on parameters or whatever. This is just a bunch of getters that do the same thing every time.