search

php-school / learn-you-php

🏆 Learn You PHP! - An introduction to PHP's core features: i/o, http, arrays, exceptions and so on.
http://www.phpschool.io/
MIT License
319 stars 36 forks source link

Time Server #9

Closed AydinHassan closed 8 years ago

AydinHassan commented 8 years ago

TODO

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #9 into master will not affect coverage as of 9253751

@@            master      #9   diff @@
======================================
  Files            7       9     +2
  Stmts          184     223    +39
  Branches         0       0       
  Methods         57      66     +9
======================================
+ Hit            184     223    +39
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 9253751

Powered by Codecov. Updated on successful CI builds.

mikeymike commented 8 years ago

Travis failed... got the same error locally trying too after composer install but works after composer update :+1:

mikeymike commented 8 years ago

Also getting exception when running verify against the solution. It's the unsafe to use system timezone so potential simple fix. Don't think we can rely on the user to have configured PHP to prevent this.

AydinHassan commented 8 years ago

@mikeymike I think I'm gonna tackle this a different way. Basically any date exercise we would need to tell the user to do this, which is annoying. I'm thinking maybe we can just do it automatically, like inject code. So I'm going to investigate a way maybe exercises can prepend code or wrap code in submissions.

AydinHassan commented 8 years ago

Hhmm that test failure is annoying. Maybe that number isn't consistent across versions, i'll have to do a regex match

AydinHassan commented 8 years ago

:rage4: GOD DAMN WINDOWS