search

php-slack / slack

A simple PHP package for sending messages to Slack, with a focus on ease of use and elegant syntax.
BSD 2-Clause "Simplified" License
135 stars 27 forks source link

Support php 8 #57

Closed esetnik closed 3 years ago

esetnik commented 3 years ago

I just opened this issue to start the conversation about any issues that come up when running the package in php 8

alek13 commented 3 years ago

56

phpfui commented 3 years ago

Can we get a PHP 8.0 compatible release? I think it is ready to go. Either 1.12.1 or 1.13.0 would work. Probably 1.12.1 as there are no real code changes, just support files.

Thanks!

alek13 commented 3 years ago

@phpfui I hope this week I will have time to have a look.

there are no real code changes, just support files

not quite..

56 was merged into master (ver. 2.x-dev), not into 1.0 branch (ver. 1.x).

And in master we have some new features.

esetnik commented 3 years ago

@alek13 just checking in on this. Is there any plans to release the php 8 compatible code?

rubenvanassche commented 3 years ago

Any updates on this?

alek13 commented 3 years ago

Support PHP 8.0 in https://github.com/php-slack/slack/releases/tag/2.0.0

phpfui commented 3 years ago

Nice! Love the dropping PHP 5 and 7.0 support. Great way to move forward. Thanks for the PHP 8.0 support.

rubenvanassche commented 3 years ago

Thank you @alek13!