php-slack / slack

A simple PHP package for sending messages to Slack, with a focus on ease of use and elegant syntax.
BSD 2-Clause "Simplified" License
135 stars 27 forks source link

php 8.0 compatibility warning when running phpcs #81

Closed 8ctopus closed 2 years ago

8ctopus commented 2 years ago
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------

LINE 2: ERROR 'object' is a soft reserved keyword as of PHP version 7.0 and a reserved keyword as of PHP version 7.2 and should not be

              used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
--------------------------------------------------------------------------------------------------------------------------------------

   1:  <?php
>> 2:  namespace Maknz\Slack\Object;

If you need a hand, I can create a pull request for it.

cmbuckley commented 2 years ago

Thanks, a PR would be appreciated. A better name for the namespace would probably be CompositionObject to match the abstract class and the Slack reference.

8ctopus commented 2 years ago

OK, on my way.