search

php-stubs / woocommerce-stubs

WooCommerce function and class declaration stubs for static analysis
https://packagist.org/packages/php-stubs/woocommerce-stubs
MIT License
83 stars 10 forks source link

woocommerce 6.0 stubs missing #12

Closed kkmuffme closed 2 years ago

kkmuffme commented 2 years ago

woocommerce 6.0 stubs missing

szepeviktor commented 2 years ago

Hello @kkmuffme! 👋

WC 6.0 is not released yet. https://github.com/woocommerce/woocommerce/tags

thejamescollins commented 2 years ago

Hi @szepeviktor,

WooCommerce has today added the 6.0.0 tag: https://github.com/woocommerce/woocommerce/releases/tag/6.0.0

Thank you

szepeviktor commented 2 years ago

Thank you! I'm also subscribed to their release feed and I talk to them regularly.

Packagist does not update!!! https://packagist.org/packages/woocommerce/woocommerce.json

thejamescollins commented 2 years ago

The WooCommerce composer package is currently broken due to switching to a mono repo structure in WC 6.0.

In the interim is it feasible to build the stubs from another source, such as a WordPress.org zip file perhaps?

szepeviktor commented 2 years ago

As you wish. But only this time.

thejamescollins commented 2 years ago

I'm happy to attempt a PR if you're open to accepting one as a one-off?

szepeviktor commented 2 years ago

Done 🍏 https://github.com/php-stubs/woocommerce-stubs/releases/tag/v6.0.0

thejamescollins commented 2 years ago

Thank you very much @szepeviktor đŸ’¯

timnolte commented 2 years ago

@om4james & @szepeviktor it appears that this PR has broken the tags in the repo. Not all releases are being made available. It appears that only the latest patch release of each minor version are being tagged.

szepeviktor commented 2 years ago

only the latest patch release of each minor version are being tagged

Yes, my release script does that. https://github.com/php-stubs/woocommerce-stubs/issues/13#issuecomment-1113930264

Patch versions - in theory - must not have a difference in stubs. I'm very sad about the the unavailability of WC as a package. Not willing to do manual job!!!

szepeviktor commented 2 years ago

@timnolte Please contact the WC release team. Open an issue there.

But pleeeease-pleeeese do not mention me. I've given up helping them.

timnolte commented 2 years ago

Ah, OK, I didn't realize. ☚ī¸ I really appreciate your time and efforts. Thanks!