php-telegram-bot / laravel

Laravel package for PHP Telegram Bot Library
Other
168 stars 50 forks source link

Update readme.md #48

Closed Lui22 closed 1 year ago

Lui22 commented 1 year ago

Make installation guide more clear by adding publish commands

Vyachee commented 1 year ago

Support! Lenin handsome

TiiFuchs commented 1 year ago

There is no need to publish those configuration files. Only if you want to change something. But I agree, that we should include it in the README.

But the Installation section is the wrong place for it.

Lui22 commented 1 year ago

There is no need to publish those configuration files. Only if you want to change something. But I agree, that we should include it in the README.

But the Installation section is the wrong place for it.

But without publishing I wasn't able to use library

TiiFuchs commented 1 year ago

Then something went wrong.

Laravel auto-discovers the ServiceProvider which loads the files from the vendor folder if you didn't publish it.

noplanman commented 1 year ago

@TiiFuchs Where should those instructions go? Maybe we can merge here and then move them in a next version?

TiiFuchs commented 1 year ago

The changed proposed here, are not the right way IMHO. I agree, that we should add a few things to the readme, and I'd do that, but I need to check it out and test a few things, because I myself no longer know exactly how everything works. 🙈

I will close this, and add an issue for the improved readme instructions