php-tmdb / api

PHP 7.3+ API Wrapper for The Movie Database
MIT License
405 stars 112 forks source link

Get "production_compagnies" and "production_companies" for a Movie #29

Closed Florian-B closed 10 years ago

Florian-B commented 10 years ago

Hi,

Very good job ! So, I have a little request, when I load a movie with :

$repository = new \Tmdb\Repository\MovieRepository($client); $movie = $repository->load([move_id]);

The movie object doesn't have information concerning "production_compagnies" and "production_countries". Whereas the The Movie Database API send this informations.

Thanks a lot

wtfzdotnet commented 10 years ago

Looking into it right now.

wtfzdotnet commented 10 years ago

@Florian-B if you are using composer, please update the reference to dev-master for time being. The official version will arrive in an update when I get the time to add the latest changes of the TMDB API.

wtfzdotnet commented 10 years ago

And by the way you were absolutely right, the construction of these 2 properties was missing in the Factory ( the scope is quite big for not everything I use and I did rush some area's ;) ). If you happen to find anything else please do report it! Thanks

Florian-B commented 10 years ago

Thanks a lot for your reactivity, I will apply your update soon.

wtfzdotnet commented 10 years ago

No problem! If you have any non-bug-related questions please head off to the google+ community as described in the readme! If you could share what you are using the library for that would be awesome :-) I'm very curious!

Florian-B commented 10 years ago

Of course, with pleasure! But, for the moment I just started this project development .

wtfzdotnet commented 10 years ago

I understand, if you'd like to tell me in private it would be appreciated, even if you have questions feel free to talk to me through hangouts : michael@wtfz.net. I'm dying to know what people use this library for.