search

php-translation / converter

Convert your translation files to Xliff
MIT License
17 stars 4 forks source link

Tag a new version #7

Open tristanbes opened 5 years ago

tristanbes commented 5 years ago

Or we can't use it with Symfony4 without a new tag :-)

Thanks :-)

emri99 commented 5 years ago

@Nyholm I can help to fix travis build, just point me the direction.

For what I experiment on recent travis usage with recommended .travis.yml from Best Practices for Reusable Bundles, I can imagine several solutions:

Both solutions have drawbacks, but I don't know better ones.

I achieve similar goal by:

It's not a perfect but it works.

Do you have a better solution ? Please let me know :)

Related issue: https://github.com/composer/composer/issues/7240

Nyholm commented 5 years ago

Thank you.

Yes, lets fix the build and tag a new version. Im all for updating the dependencies to be more specific. If you also think travis.yml can be simpler please feel free to update.

Btw, I wrote that section of best practices =) But I think it was after I created this library.

emri99 commented 5 years ago

Hey !

On my way to fix builds, I don't know how to handle deprecation warning:

Remaining deprecation notices (5)
  5x: Creating a backup while dumping a message catalogue is deprecated since Symfony 3.1 and will be removed in 4.0. Use TranslationWriter::disableBackup() to disable the backup.
    4x in ConverterTest::testConvertJMS from Translation\Converter\Tests\Functional\Service
    1x in ConverterTest::testConvertYaml from Translation\Converter\Tests\Functional\Service
Script vendor/bin/simple-phpunit handling the test event returned with error code 1
The command "$TEST_COMMAND" exited with 1.

from: https://travis-ci.org/emri99/converter/jobs/536334862#L631

Adding SYMFONY_DEPRECATIONS_HELPER="weak" fix travis build #7.3 compared to builds #\6, but seems like a bad idea to hide those warnings every where as this is the reason of remaining jobs failures.

Should I hide those warnings ? only for some versions ? Should I modify source code to remove deprecated code in Converter ?

Thank you :)