Extractors for Knp Menu wanted?

[Guite]

I have implemented extractors for:

• KnpMenu item labels ($menu->addChild('foo') and $menu['foo']->setLabel('bar'))
• KnpMenu item link titles ($menu['foo']->setLinkAttribute('title', 'my.title'))

You can see them here: https://github.com/zikula/core/tree/master/src/lib/Zikula/Bundle/CoreBundle/Translation/Extractor/Visitor/Php/Knp/Menu

If desired I can contribute them back.

cc @odolbeau

[odolbeau]

That's a good question! I don't know if the goal of this lib is to provide as much extractors as possible or to only provide "base" extractors. Only @Nyholm has the answer I guess. :)

[Nyholm]

Interesting. Hm. Since this library follows open close principle very well and you can easily include the extractors you want, I don’t see any issue adding KnpLabs stuff like this. Especially since KnpLabs is super popular.

[Guite]

More information here: https://symfony.com/doc/master/bundles/KnpMenuBundle/i18n.html

[Guite]

Closed as added and merged in #152.