refac: add return type to fix deprecation

php-translation / extractor

Extracts translation strings from source code

MIT License

126 stars 33 forks source link

refac: add return type to fix deprecation #161

Closed gimler closed 2 years ago

gimler commented 2 years ago

Fix deprecation message in symfony 5.4

Method "Twig\NodeVisitor\NodeVisitorInterface::getPriority()" might add "int" as a native return type declaration in the future. Do the same in implementation "Translation\Extractor\Visitor\Twig\TwigVisitor" now to avoid errors or add an explicit @return annotation to suppress this message.

gimler commented 2 years ago

phpcs fixed with #163

bocharsky-bw commented 2 years ago

Thank you for this PR!

Looks like we do not run tests in this repo yet - as you see Travis CI is dead. I think we need to port test workflow from symfony-bundle repo to see tests are still green here. I'll create a PR to bring tests back

bocharsky-bw commented 2 years ago

Tests are alive! Please, rebase

gimler commented 2 years ago

@bocharsky-bw green. please make also a new release after merge ;)