php-translation / loco-adapter

Adapter for Localise.biz
MIT License
25 stars 37 forks source link

Considering symfony/http-client instead of Httplug #52

Open welcoMattic opened 4 years ago

welcoMattic commented 4 years ago

As we now support Symfony >=5.0, we could migrate from Httplug to symfony/http-client. It will remove an external dependency (if you're using php-translation/symfony-bundle).

Symfony HTTP Client offers same features as Httplug, full support of HTTP protocol, many clients per application by configuration, ...

WDYT @Nyholm @odolbeau?

EDIT: Main discussion will be here, after decision we will open or not issues on other adapters repositories.

odolbeau commented 4 years ago

I agree with you. I think we already discussed about this topic with @Nyholm but I can't find where it was... :/