search

php-translation / phraseapp-adapter

Adapter for Phraseapp
MIT License
2 stars 5 forks source link

Truncated translation token #16

Open gaetan-petit opened 5 years ago

gaetan-petit commented 5 years ago

When downloading, translation tokens get truncated:

community_agenda.title

becomes

agenda.title

I don't know why the domain + 2 chars are supposed to get substr() as we never have the domain in the translation token.

Any idea @prolic ?

prolic commented 5 years ago

just put something like "default" in your token as domain then.

gaetan-petit commented 5 years ago

@prolic tell me if I'm wrong:

I'm not sure on how to deal with all the messages that does not have a domain prefix, and how to keep translation having the consistent tag in PhraseApp.

Any advice?

prolic commented 5 years ago

Sorry, i used phraseapp a while ago. Can't remember all the details.

On Thu, Jan 17, 2019, 09:43 Gaëtan Petit <notifications@github.com wrote:

@prolic https://github.com/prolic tell me if I'm wrong:

  • The adapter assume that your translation tokens have their domain as a prefix
  • In PhraseApp the tokens are tagged with a tag having the same name as the domain they belong

I'm not sure on how to deal with all the messages that does not have a domain prefix, and how to keep translation having the consistent tag in PhraseApp.

Any advice?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/php-translation/phraseapp-adapter/issues/16#issuecomment-455088800, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYEvE9-6zusip_U971A4-_kGA7O013tks5vEDe3gaJpZM4aC15V .

gaetan-petit commented 5 years ago

@Nyholm could you help?