search

php-translation / symfony-bundle

Symfony integration for Translations
MIT License
327 stars 94 forks source link

Order of translations seems random #404

Open Guite opened 4 years ago

Guite commented 4 years ago

This could be related to #398 but I am not sure about that.

We've setup a GitHub Action workflow which should regularly extract translations and create a pull request for adding missing messages.

But it seems that the order of messages in a catalogue is changed every time. Maybe it would be possible to change that in order to use a "fixed order" instead?

Here is an example: https://github.com/zikula/core/pull/4123 If you look at the diff you'll see that it moves messages around which did not change actually.

odolbeau commented 4 years ago

I tried on my local installation but I don't have this problem. In my case, with loco, everything is fine, I can download translations several times, the generated translation file will always be the same.

I guess it depends on the adapter you're using?

Guite commented 4 years ago

I guess it depends on the adapter you're using?

That would be Filesystem then.

odolbeau commented 4 years ago

Which command is used during this automatic PR? Is it translation:download or translation:update. Could you please give a try to both of them to see if you have the same problem?

(May be linked to #392)

Guite commented 4 years ago

We use translation:extract.

Guite commented 4 years ago

Here is what we execute as part of this workflow: https://github.com/zikula/core/blob/200a283e95dbabbf4716bdc18e838bb89d1bac7f/.github/workflows/update-translations.yml#L31

odolbeau commented 4 years ago

which should regularly extract translations Obviously, it was already said! ^^

Looks like it's definitively the same issue described in #398.