php-translation / symfony-bundle

Symfony integration for Translations
MIT License
327 stars 94 forks source link

Add support for PHP 8 #424

Closed lepiaf closed 3 years ago

lepiaf commented 3 years ago

PR for issue https://github.com/php-translation/symfony-bundle/issues/423

lepiaf commented 3 years ago
composer update ${COMPOSER_FLAGS} --prefer-dist --prefer-stable --no-interaction

Loading composer repositories with package information

Updating dependencies

Your requirements could not be resolved to an installable set of packages.

  Problem 1

    - php-translation/symfony-storage[dev-master, 2.1.0, ..., 2.2.0] require php ^7.2 -> your php version (8.0.0) does not satisfy that requirement.

    - php-translation/symfony-storage 2.2.x-dev is an alias of php-translation/symfony-storage dev-master and thus requires it to be installed too.

    - Root composer.json requires php-translation/symfony-storage ^2.1 -> satisfiable by php-translation/symfony-storage[2.1.0, 2.2.0, 2.2.x-dev (alias of dev-master)].

I've opened a PR https://github.com/php-translation/symfony-storage/pull/51

lepiaf commented 3 years ago

I've also open a PR to https://github.com/php-translation/extractor/pull/157

Ciloe commented 3 years ago

Any advance on this PR ?

Kocal commented 3 years ago

Hi, is there any updates for this?

Thanks!

welcoMattic commented 3 years ago

Hi, I'm sorry, I have not free time to work on PHP8 support PRs those days (major incident on a famous French hosting company) + coming deadline to finish https://github.com/symfony/symfony/pull/38475. May be @bocharsky-bw or @rvanlaak are available to review those PRs?

Kocal commented 3 years ago

No worries, I know you are hard working for adding translations providers for Symfony. Keep up the good work! :muscle:

bocharsky-bw commented 3 years ago

Thank you for working on this and sorry for the slow replies!

Currently, this PR is blocked by https://github.com/php-translation/symfony-storage/pull/51 and waiting for it to be merged first

Nyholm commented 3 years ago

There are some CI jobs that fail. But they are not related to this PR.

Thank you for your work.