search

php-translation / symfony-bundle

Symfony integration for Translations
MIT License
327 stars 94 forks source link

Migrate PHPUnit configuration #466

Closed bocharsky-bw closed 2 years ago

bocharsky-bw commented 2 years ago

From the CLI:

$ ./vendor/bin/simple-phpunit
PHPUnit 9.5.13 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing
............................................................      60 / 60 (100%)
bocharsky-bw commented 2 years ago

Oh, good catch Richard, thanks! Well, not sure why exactly, but looks like somehow the bundle users different PHPUnit version in different build, probably that's the default version for that set of deps. I forced the latest PHPUnit 9.5 with the env var, it should be good now except 7.2 build, but I opened another related PR, see #467

rvanlaak commented 2 years ago

Different versions of PHPUnit get used because simple-phpunit is used, which does an isolated composer update and pins PHPUnit to 8.x for older versions of PHP.

Imho it is fine to leave this deprecation on the PHPUnit configuration as long as we do not do a cleanup as discussed in https://github.com/php-translation/symfony-bundle/pull/467