php-translation / symfony-bundle

Symfony integration for Translations
MIT License
327 stars 93 forks source link

[WebUI] Filter on profiler token #67

Open rvanlaak opened 7 years ago

rvanlaak commented 7 years ago

Would be great if the web UI would be able to filter on a profiler token. Since 2.7 the profiler collects all translations: https://github.com/symfony/symfony/pull/14003

Also see https://github.com/lexik/LexikTranslationBundle/issues/165

Nyholm commented 7 years ago

I do not think that is a part of the WebUI. The feature is available by the Profiler integration.

How to enable: http://php-translation.readthedocs.io/en/latest/symfony/profiler-ui.html

Image: https://raw.githubusercontent.com/Happyr/TranslationBundle/master/src/Resources/doc/images/missing-translation-example.gif Image: https://raw.githubusercontent.com/Happyr/TranslationBundle/master/src/Resources/doc/images/edit-flag-sync-example.gif

rvanlaak commented 7 years ago

Yes I know it's not part of the WebUI, but that basically is my feature request; being able to filter based on the profiler tokens. Could be an easy way for developers to do translations; navigate a request, and thereafter "goto last request" in the Web UI.

Nyholm commented 7 years ago

Im saying that you can do that already. But you have to use the symfony profiler integration.

The profiler integration provides that exact functionality and the WebUI is for editing all your translations.

If one would merge the two we have to duplicate the functionality from Symfony where they show/select profiler tokens and load the data collected.

rvanlaak commented 7 years ago

The main reason for this feature request is that the WebUI also shows the translations in the other locales. Yes I agree that functionality is comparable, but I think that the WebUI eventually would be able to give a better translation experience as the profiler would be able to do.

So it might be a nice discussion to determine what place is preferable for new features, the webUI or the profiler 👍

Nyholm commented 7 years ago

WebUI also shows the translations in the other locales.

Ah, I see. I actually had that problem. I usually go to Loco and translate new strings there.

👍

rvanlaak commented 7 years ago

I'm still in the process of trying to find out whether we would still need an external translation service. As we really prefer translating based on requests, I started submitting feature requests based on that. I hope that we eventually don't need an "extra" piece of software for our translations :)

So, yes I agree that some features duplicate existing behavior (profiler vs. WebUI), but I don't think they would block each other. Eventually from the perspective of the translator this integration between both should work seamlessly.