Support mutiple strings in same request

[Korbeil]

Issues

• Fixes #13

Content

• Updating TranslatorService interface with translateArray(array $strings, string $from, string $to): array method.
• Creating AbstractTranslator to handle default behavior for translateArray() (which is just calling translate() method for all strings).
• Updating ChainedTranslator with new translateArray() method & updating translate() method.
• Moving format() method to AbstractTranslator & making it fixing translated string with first letter uppercase when original isn't.
• Abstracting translator tests & implementing it for all of them.

[Korbeil]

Any news ?

[Korbeil]

@Nyholm should we merge this ?

[Korbeil]

@Nyholm update :)

[welcoMattic]

May @bocharsky-bw or @Nyholm could review this 1 year old PR? :wink:

[bocharsky-bw]

Only @Nyholm can merge commits with failed TravisCI :/ We need to make tests green here first, then I'd be able to merge

UPD: Oh, wait, I even don't have access to this repo 😇

[Korbeil]

Only @Nyholm can merge commits with failed TravisCI :/ We need to make tests green here first, then I'd be able to merge

Tests are red cause HHVM does not support PHP anymore :) I already fixed it in https://github.com/php-translation/translator/pull/20

[bocharsky-bw]

I see #20 is merged, so could you rebase this PR with master? :)

[Korbeil]

@bocharsky-bw It's red on PHP 5.5, it's probably time to drop it ? What you think about it ?

See https://github.com/php-translation/translator/pull/21

[welcoMattic]

I think we can drop support of PHP 5.5 as its end of life was in 2016 ...

[Korbeil]

Just saw but, PHP 5.5 does not work since long time on Travis, see https://travis-ci.org/php-translation/translator/builds/548564414 (which was 1 month ago)

[bocharsky-bw]

Yes, let's drop 5.5 👍

Thank you for providing the PR. I think @Nyholm will be able to merge it soon

[Simperfit]

@Nyholm Do you have some time to review this please ? it seems that people will benefit from it ;)

[Nyholm]

I honestly not sure if it is beneficial or not. I've been reviewing this back and forth for a while.

It seams like the only thing we do is some refactoring and:

public function translateArray($strings, $from, $to)
    {
        $array = [];
         foreach ($strings as $string) {
            $array[] = $this->translate($string, $from, $to);
        }
         return $array;
    }

Why do we need that loop inside the implementation themselves?

[Korbeil]

@Nyholm this is only a bootstrap for https://github.com/php-translation/translator/issues/13 The idea is to send request with multiple strings to translate by default instead of translating one string by one. After that PR we have to implement this method for each provider but this translateArray will act as compatibility for all provider that don't support it already :)

[Nyholm]

Lets leave this PR for now. It contains too many refactoring and changes not related to the point you are trying to make.

Please create a new PR with a new interface that has the translateArray function and then pick one provider which implement that new interface.